Bug 151861 - Source/JavaScriptCore/create_hash_table shouldn't be too verbose
Summary: Source/JavaScriptCore/create_hash_table shouldn't be too verbose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-04 05:31 PST by Csaba Osztrogonác
Modified: 2015-12-10 04:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2015-12-04 05:32 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
build log with the proposed change (17.28 KB, text/plain)
2015-12-04 05:34 PST, Csaba Osztrogonác 		no flags Details
build log without the proposed change (22.82 KB, text/plain)
2015-12-04 05:38 PST, Csaba Osztrogonác 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-12-04 05:31:09 PST 
create_hash_table fills the build logs with 32 useless lines like this:
Creating hashtable for /home/ossy/WebKit/Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.cpp

I don't think is is so useful for us. Additionally it makes the one-liner ninja output longer for nothing.
If you really need verbose output, ninja already dumps lines like this:
Generating ../../DerivedSources/JavaScriptCore/IntlDateTimeFormatConstructor.lut.h
Comment 1 Csaba Osztrogonác 2015-12-04 05:32:52 PST 
Created attachment 266623 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-12-04 05:34:51 PST 
Created attachment 266624 [details]
build log with the proposed change
Comment 3 Csaba Osztrogonác 2015-12-04 05:38:13 PST 
Created attachment 266625 [details]
build log without the proposed change
Comment 4 WebKit Commit Bot 2015-12-10 04:02:03 PST 
Comment on attachment 266623 [details]
Patch

Clearing flags on attachment: 266623

Committed r193900: <http://trac.webkit.org/changeset/193900>
Comment 5 WebKit Commit Bot 2015-12-10 04:02:07 PST 
All reviewed patches have been landed.  Closing bug.