Bug 151841 – Add an option to emit instructions validating exceptions in the DFG rather than always emiting them.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Add an option to emit instructions validating exceptions in the DFG rather than always emiting them.

[Keith Miller]

Created attachment 266582 [details]
Patch

[Michael Saboff]

Comment on attachment 266582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266582&action=review

I see that Saam added these JIT asserts to help find what operations emit exception checks.  Given that you have the desire to turn them off by default, it seems to me that it makes more sense to eliminated them altogether.  Want to hear what others (Saam) think.

> Source/JavaScriptCore/runtime/Options.h:329
> +    v(bool, validateExceptionHandlingInDFG, false, nullptr) \

Add a description string for the option.

[Keith Miller]

> I see that Saam added these JIT asserts to help find what operations emit
> exception checks.  Given that you have the desire to turn them off by
> default, it seems to me that it makes more sense to eliminated them
> altogether.  Want to hear what others (Saam) think.

I spoke with Saam offline and he mirrored your opinion. Instead, I'll have the option on by default in debug builds.

> > Source/JavaScriptCore/runtime/Options.h:329
> > +    v(bool, validateExceptionHandlingInDFG, false, nullptr) \
> 
> Add a description string for the option.

Fixed.

[Keith Miller]

Created attachment 266589 [details]
Patch

[Saam Barati]

Comment on attachment 266589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266589&action=review

r=me

> Source/JavaScriptCore/jit/AssemblyHelpers.h:1005
> +    void jitReleaseAssertNoException();

We could also call this crashIfVMHasException or something like that.

[Saam Barati]

On second thought, I do like the releaseAssert name

[WebKit Commit Bot]

Comment on attachment 266589 [details]
Patch

Clearing flags on attachment: 266589

Committed r193424: <http://trac.webkit.org/changeset/193424>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.