Bug 151837 – Web Inspector: add "Save Selected" context menu item to Console

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Let's face it, most people are going to paste it and save it right away. Might as well make this easier, since it's not much work.

[Radar WebKit Bug Importer]

<rdar://problem/23752867>

[Devin Rousso]

Created attachment 304702 [details]
Patch

[Devin Rousso]

Created attachment 304703 [details]
[Image] After Patch is applied

[Joseph Pecoraro]

Comment on attachment 304702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304702&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:-879
> -    console.assert(saveData.url);
>      console.assert(saveData.content);
> -    if (!saveData.url || !saveData.content)

Rather then allow an empty URL, we can provide a default name.

For saving the entire console we use: "web-inspector:///Console.txt" to prefer a name of "Console.txt".
Here we could use "web-inspector:///ConsoleMessage(s).txt" to get something better than "Untitled"? We could localize if we wanted, but we haven't for other fake URL names.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:392
>  

Should we also have a "Save Log" next to the "Clear Log" item for the entire log case?

[Joseph Pecoraro]

Comment on attachment 304702 [details]
Patch

r=me for this as I see no problems with it, just open questions.

[Devin Rousso]

Created attachment 304709 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 304709 [details]
Patch

Clearing flags on attachment: 304709

Committed r214077: <http://trac.webkit.org/changeset/214077>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.