Bug 151836 – Web Inspector: add "Copy Selected" context menu item to Console

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Copying item(s) from console is not discoverable enough.

[Radar WebKit Bug Importer]

<rdar://problem/23752839>

[Devin Rousso]

Created attachment 286021 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 286021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286021&action=review

This patch allows to copy one console message. That's a good start. Ideally, I'd expect the context menu to do the same as Command-C — copy all selected messages.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:344
> +

Why is this needed?

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:358
> +            contextMenu.appendItem(WebInspector.UIString("Copy Selected"), () => {

You should add "Copy Selected" to localizedStrings.js.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-365
> -

Why is this needed?

[Devin Rousso]

Comment on attachment 286021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286021&action=review

>> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:344
>> +
> 
> Why is this needed?

Since a context menu is considered a "mousedown" but not a "mouseup" we need to force this event

>> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-365
>> -
> 
> Why is this needed?

This prevented the right click from even working on console entries

[Devin Rousso]

Created attachment 286026 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 286026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286026&action=review

r=me, but this should add some comments to the tricky bit.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:344
> +        if (!this._selectedMessages.length)
> +            this._mouseup(event);

This really needs a comment. It is not obvious why this needs to be here and it is not explained anywhere. What are the consequences of not doing this? Selection handling is not reset so just moving the mouse would select rows?

[Devin Rousso]

Created attachment 286150 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 286150 [details]
Patch

Clearing flags on attachment: 286150

Committed r204511: <http://trac.webkit.org/changeset/204511>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.