RESOLVED FIXED 151834
[JSC] Some more cleanup of FTLB3Output 
https://bugs.webkit.org/show_bug.cgi?id=151834
Summary [JSC] Some more cleanup of FTLB3Output
Benjamin Poulain
Reported 2015-12-03 16:25:41 PST
[JSC] Some more cleanup of FTLB3Output
Attachments
Patch (2.75 KB, patch)
2015-12-03 16:26 PST, Benjamin Poulain 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-12-03 16:26:09 PST
Created attachment 266574 [details] Patch
Filip Pizlo
Comment 2 2015-12-04 16:24:53 PST
Comment on attachment 266574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266574&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9849 > +#if FTL_USES_B3 > + // FIXME: Add B3 support. > + UNUSED_PARAM(probeFunc); > +#else // !FTL_USES_B3 > uint32_t stackmapID = m_stackmapIDs++; > m_ftlState.probes.append(ProbeDescriptor(stackmapID, probeFunc)); > m_out.call(m_out.voidType, m_out.stackmapIntrinsic(), m_out.constInt64(stackmapID), m_out.constInt32(sizeOfProbe())); > +#endif // !FTL_USES_B3 I'm not sure about this. This code isn't right for B3.
Benjamin Poulain
Comment 3 2015-12-04 18:57:17 PST
Committed r193506: <http://trac.webkit.org/changeset/193506>
Note You need to log in before you can comment on or make changes to this bug.