* SUMMARY Specifically Identify the Global Lexical Environment Scope. * STEPS TO REPRODUCE 1. shell> run-webkit-tests inspector/debugger/breakpoint-scopes.html => There is a new Closure Scope right above Global Variables, should be better named * NOTES Test is currently skipped because all debugger tests are errantly skipped right now.
<rdar://problem/23750617>
Created attachment 266564 [details] [IMAGE] With Fix
Created attachment 266565 [details] [PATCH] Proposed Fix
Attachment 266565 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:80: GLOBAL_LEXICAL_ENVIRONMENT_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 266565 [details] [PATCH] Proposed Fix Missed something.
Created attachment 266568 [details] [PATCH] Proposed Fix Fixed Debug build ASSERTs by updating the protocol for runtime-checks.
Comment on attachment 266568 [details] [PATCH] Proposed Fix LGTM
Attachment 266568 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/JSJavaScriptCallFrame.h:80: GLOBAL_LEXICAL_ENVIRONMENT_SCOPE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 266568 [details] [PATCH] Proposed Fix r=me too, assuming it passes EWS.
<http://trac.webkit.org/changeset/193425>