Bug 151803 - [WinCairo][MediaFoundation] Main thread can block when session is destroyed.
Summary: [WinCairo][MediaFoundation] Main thread can block when session is destroyed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-03 07:01 PST by peavo
Modified: 2015-12-03 11:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.33 KB, patch)
2015-12-03 07:08 PST, peavo 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-12-03 07:01:55 PST 
I thought I fixed this in http://trac.webkit.org/changeset/192578, but it turns out it wasn't fixed properly. This time for real :)
Comment 1 peavo 2015-12-03 07:08:09 PST 
Created attachment 266528 [details]
Patch
Comment 2 Alex Christensen 2015-12-03 10:04:30 PST 
Comment on attachment 266528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266528&action=review

> Source/WebCore/ChangeLog:8
> +        Set flag make sure that the scheduler thread stops when the session ends.

...to make sure...
Comment 3 peavo 2015-12-03 11:32:55 PST 
(In reply to comment #2)
> Comment on attachment 266528 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266528&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Set flag make sure that the scheduler thread stops when the session ends.
> 
> ...to make sure...

Will fix, thanks for reviewing :)
Comment 4 peavo 2015-12-03 11:33:45 PST 
Committed r193353: <http://trac.webkit.org/changeset/193353>.