WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
151802
[css-grid] margin-left:auto and margin-top:auto discards the margin on opposite side
https://bugs.webkit.org/show_bug.cgi?id=151802
Summary
[css-grid] margin-left:auto and margin-top:auto discards the margin on opposi...
Javier Fernandez
Reported
2015-12-03 02:24:47 PST
Created
attachment 266524
[details]
test cases It seems that when some of the margins are auto, the other specified margins are just ignored. The issue is affecting margins in all directions, as it can be appreciated in the attached test case.
Attachments
test cases
(770 bytes, text/html)
2015-12-03 02:24 PST
,
Javier Fernandez
no flags
Details
Patch
(6.79 KB, patch)
2015-12-03 06:20 PST
,
Javier Fernandez
no flags
Details
Formatted Diff
Diff
Patch
(6.78 KB, patch)
2015-12-03 08:14 PST
,
Javier Fernandez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Javier Fernandez
Comment 1
2015-12-03 06:20:30 PST
Created
attachment 266527
[details]
Patch
Sergio Villar Senin
Comment 2
2015-12-03 07:24:01 PST
Comment on
attachment 266527
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=266527&action=review
r=me
> LayoutTests/fast/css-grid-layout/grid-item-auto-margins-must-respect-specified-margins.html:3 > +<head>
No need for <html> nor <head> tags
> LayoutTests/fast/css-grid-layout/grid-item-auto-margins-must-respect-specified-margins.html:73 > +</div>
Close the <body> tag
Javier Fernandez
Comment 3
2015-12-03 08:14:16 PST
Created
attachment 266529
[details]
Patch Aplied suggested changes.
WebKit Commit Bot
Comment 4
2015-12-03 09:57:28 PST
Comment on
attachment 266529
[details]
Patch Clearing flags on attachment: 266529 Committed
r193000
: <
http://trac.webkit.org/changeset/193000
>
WebKit Commit Bot
Comment 5
2015-12-03 09:57:31 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug