Bug 151797 – [GTK] Test /webkit2/WebKitWebResource/get-data is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

Since we switched to use the network process to run the unit tests the test /webkit2/WebKitWebResource/get-data sometimes fails and sometimes passes:

ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:194:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached

FAIL

This is because now the FIXME there doesn't seem to apply anymore:

// FIXME: this should be 4 instead of 3, but we don't get the css image resource
// due to bug https://bugs.webkit.org/show_bug.cgi?id=78510.
test->waitUntilResourcesLoaded(3);

We are now also getting the notification for the css image. Since we wait for 3 resources, sometimes the css image is loaded before and then checkResourceData is called for it, but not handled. When the css image is the last one loaded the test passes. So, we just need to wait for the 4 resources.

[Carlos Garcia Campos]

Created attachment 266515 [details]
Patch

[Carlos Garcia Campos]

Committed r193412: <http://trac.webkit.org/changeset/193412>