Bug 151790 - Uncaught Exception in Web Inspector: TypeError: null is not an object (evaluating 'dataGridNode.element.classList')
Summary: Uncaught Exception in Web Inspector: TypeError: null is not an object (evalua...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-02 20:41 PST by Joseph Pecoraro
Modified: 2015-12-03 14:06 PST (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (3.76 KB, patch)
2015-12-03 13:07 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (3.79 KB, patch)
2015-12-03 13:17 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-12-02 20:41:48 PST 
* SUMMARY
Uncaught Exception in Web Inspector

TypeError: null is not an object (evaluating 'dataGridNode.element.classList') (at file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Views/TreeOutlineDataGridSynchronizer.js:282:29)

* STEPS TO REPRODUCE
1. Inspect about:blank
2. js> var i = 0; setInterval(function() { console.log("log", ++i); }, 1000)
3. Start a timeline
4. Select the JavaScript & Events timeline
5. Wait about 20 seconds (for the timeline to start scrolling and stuff)
  => Exception
Comment 1 Radar WebKit Bug Importer 2015-12-02 20:42:13 PST 
<rdar://problem/23737405>
Comment 2 Matt Baker 2015-12-03 13:07:48 PST 
Created attachment 266550 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2015-12-03 13:13:35 PST 
Comment on attachment 266550 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266550&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1331
> +        this._hidden = x;

x || false;

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1333
> +            this._element.classList.toggle("hidden");

Should pass this._hidden as the second arg.
Comment 4 Matt Baker 2015-12-03 13:17:22 PST 
Created attachment 266551 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2015-12-03 14:06:32 PST 
Comment on attachment 266551 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 266551

Committed r193375: <http://trac.webkit.org/changeset/193375>
Comment 6 WebKit Commit Bot 2015-12-03 14:06:34 PST 
All reviewed patches have been landed.  Closing bug.