* SUMMARY Remote Web Inspector: RemoteInspector::sendMessageToRemote with null connection. * STEPS TO REPRODUCE 1. Launch Application with JSContext 2. Launch Safari 3. Safari: Develop > Current Machine > App > Context 4. Close Remote Inspection window while doing stuff => Possible CRASH * NOTES Previously the connection was null checked (as it could have been removed by another thread). It seems we lost the null check. (lldb) p connection (Inspector::RemoteConnectionToTarget *) $3 = 0x0000000000000000 > void RemoteInspector::sendMessageToRemote(unsigned identifier, const String& message) > { > ... > auto connection = m_connectionMap.get(identifier); > > NSDictionary *userInfo = @{ > WIRRawDataKey: [static_cast<NSString *>(message) dataUsingEncoding:NSUTF8StringEncoding], > WIRConnectionIdentifierKey: connection->connectionIdentifier(), > WIRDestinationKey: connection->destination() > }; > ... > }
<rdar://problem/23737051>
Created attachment 266501 [details] [PATCH] Proposed Fix
Comment on attachment 266501 [details] [PATCH] Proposed Fix Clearing flags on attachment: 266501 Committed r193355: <http://trac.webkit.org/changeset/193355>
All reviewed patches have been landed. Closing bug.