Bug 151787 - REGRESSION(r192753): Remote Web Inspector: Applications and Debuggables not showing up in debuggers
Summary: REGRESSION(r192753): Remote Web Inspector: Applications and Debuggables not s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-02 18:48 PST by Joseph Pecoraro
Modified: 2015-12-02 20:05 PST (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.41 KB, patch)
2015-12-02 18:50 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-12-02 18:48:13 PST 
* SUMMARY
Applications and Debuggables not showing up in debuggers.

* STEPS TO REPRODUCE
1. Launch application with JSContext
2. Launch Safari
3. Show Develop menu
4. Hover the JSContext (to trigger Indication)
5. Quit Safari
6. Launch Safari again
7. Show Develop menu
  => Application and JSContext not listed

* NOTES
Sampling the application with JSContext results in unexpected time hanging in receivedIndicateMessage:

>  2526 Inspector::RemoteInspectorXPCConnection::handleEvent
>    2526 Inspector::RemoteInspector::xpcConnectionReceivedMessage
>      2526 Inspector::RemoteInspector::receivedIndicateMessage
>        2526 WTF::LockBase::lockSlow
>          2526 WTF::ParkingLot::parkConditionally
>            2526 std::__1::condition_variable::wait
>              2526 _pthread_cond_wait
>                2526 __psynch_cvwait

Seems there was an errant lock_guard added to RemoteInspector::receivedIndicateMessage that did nothing, but caused this.
Comment 1 Joseph Pecoraro 2015-12-02 18:48:25 PST 
<rdar://problem/23728977>
Comment 2 Joseph Pecoraro 2015-12-02 18:50:16 PST 
Created attachment 266494 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-12-02 20:05:23 PST 
Comment on attachment 266494 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 266494

Committed r192991: <http://trac.webkit.org/changeset/192991>
Comment 4 WebKit Commit Bot 2015-12-02 20:05:28 PST 
All reviewed patches have been landed.  Closing bug.