Bug 151786 - Reduce size of ScriptElement
Summary: Reduce size of ScriptElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-02 18:26 PST by Alex Christensen
Modified: 2015-12-02 19:29 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.73 KB, patch)
2015-12-02 18:31 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.69 KB, patch)
2015-12-02 19:18 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-12-02 18:26:40 PST
Reduce size of ScriptElement
Comment 1 Alex Christensen 2015-12-02 18:31:46 PST
Created attachment 266493 [details]
Patch
Comment 2 Alex Christensen 2015-12-02 18:36:37 PST
This reduces the sizeof(ScriptElement) from 168 to 56 bytes, like it was before https://bugs.webkit.org/show_bug.cgi?id=151649
Comment 3 Andreas Kling 2015-12-02 18:39:52 PST
Comment on attachment 266493 [details]
Patch

r=me
Comment 4 Andreas Kling 2015-12-02 18:52:05 PST
Maybe we could use callOnMainThread() with a captured RefPtr<ScriptElement> to keep it alive here? Then we'd shrink the object even more :)
Comment 5 Alex Christensen 2015-12-02 19:18:05 PST
Created attachment 266499 [details]
Patch
Comment 6 WebKit Commit Bot 2015-12-02 19:29:38 PST
Comment on attachment 266499 [details]
Patch

Clearing flags on attachment: 266499

Committed r192989: <http://trac.webkit.org/changeset/192989>
Comment 7 WebKit Commit Bot 2015-12-02 19:29:43 PST
All reviewed patches have been landed.  Closing bug.