Bug 151785 - [ES6] Add several generator related JSRegress tests to measure performance change after optimization
Summary: [ES6] Add several generator related JSRegress tests to measure performance ch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-02 18:26 PST by Yusuke Suzuki
Modified: 2015-12-10 08:38 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.12 KB, patch)
2015-12-02 18:27 PST, Yusuke Suzuki 		saam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (874.31 KB, application/zip)
2015-12-02 19:11 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (893.02 KB, application/zip)
2015-12-02 19:12 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (948.08 KB, application/zip)
2015-12-02 19:16 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-12-02 18:26:33 PST 
[ES6] Add several generator related JSRegress tests to measure performance change after optimization
Comment 1 Yusuke Suzuki 2015-12-02 18:27:08 PST 
Created attachment 266492 [details]
Patch
Comment 2 Saam Barati 2015-12-02 18:52:52 PST 
Comment on attachment 266492 [details]
Patch

r=me
It might also be cool to convert some well known benchmark to use generators/iterator protocol/for...of and see how we perform.
Comment 3 Build Bot 2015-12-02 19:11:39 PST 
Comment on attachment 266492 [details]
Patch

Attachment 266492 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/509126

New failing tests:
js/regress/generator-function-create.html
js/regress/generator-with-several-types.html
js/regress/generator-create.html
js/regress/generator-fib.html
Comment 4 Build Bot 2015-12-02 19:11:41 PST 
Created attachment 266496 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2015-12-02 19:11:58 PST 
Comment on attachment 266492 [details]
Patch

Attachment 266492 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/509158

New failing tests:
js/regress/generator-function-create.html
js/regress/generator-with-several-types.html
js/regress/generator-create.html
js/regress/generator-fib.html
Comment 6 Build Bot 2015-12-02 19:12:00 PST 
Created attachment 266497 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2015-12-02 19:16:27 PST 
Comment on attachment 266492 [details]
Patch

Attachment 266492 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/509164

New failing tests:
js/regress/generator-function-create.html
js/regress/generator-with-several-types.html
js/regress/generator-create.html
js/regress/generator-fib.html
Comment 8 Build Bot 2015-12-02 19:16:29 PST 
Created attachment 266498 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 9 Yusuke Suzuki 2015-12-10 08:36:55 PST 
(In reply to comment #2)
> Comment on attachment 266492 [details]
> Patch
> 
> r=me
> It might also be cool to convert some well known benchmark to use
> generators/iterator protocol/for...of and see how we perform.

Thanks. I've just converted access-nsieve to generator style and added it :)
Comment 10 Yusuke Suzuki 2015-12-10 08:38:29 PST 
Committed r193907: <http://trac.webkit.org/changeset/193907>