Bug 151775 - Fix authentication requests with NetworkSession and canHandleHTTPSServerTrustEvaluation true
Summary: Fix authentication requests with NetworkSession and canHandleHTTPSServerTrust...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-02 14:20 PST by Alex Christensen
Modified: 2015-12-02 15:51 PST (History)
0 users

See Also:

Attachments
Patch (6.06 KB, patch)
2015-12-02 14:24 PST, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-12-02 14:20:10 PST 
Fix authentication requests with NetworkSession and canHandleHTTPSServerTrustEvaluation true
Comment 1 Alex Christensen 2015-12-02 14:24:27 PST 
Created attachment 266471 [details]
Patch
Comment 2 Alex Christensen 2015-12-02 15:17:12 PST 
rdar://problem/23586265
Comment 3 Chris Dumez 2015-12-02 15:18:38 PST 
Comment on attachment 266471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266471&action=review

r=me with suggestion

> Source/WebKit2/NetworkProcess/NetworkLoad.cpp:-284
> -    notImplemented();

I would just do a: "auto completionHandler = WTF::move(m_completionHandler);" here, to avoid having to nullify m_completionHandler in all the branches.
Comment 4 Alex Christensen 2015-12-02 15:51:30 PST 
http://trac.webkit.org/changeset/192982