RESOLVED FIXED151764
Fix social meta for home page 
https://bugs.webkit.org/show_bug.cgi?id=151764
Summary Fix social meta for home page
Jon Davis
Reported 2015-12-02 12:22:49 PST
The social meta for schema.org, Twitter Card and Open Graph is not useful for the homepage.
Attachments
Patch (4.76 KB, patch)
2015-12-07 16:02 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (5.70 KB, patch)
2015-12-08 09:48 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (5.86 KB, patch)
2015-12-08 11:38 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2015-12-07 16:02:44 PST
Created attachment 266824 [details] Patch
Timothy Hatcher
Comment 2 2015-12-07 16:10:25 PST
Comment on attachment 266824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266824&action=review > Websites/webkit.org/wp-content/plugins/social-meta.php:42 > +<?php if ( '' !== ( $twitter_handle = get_the_author_meta('twitter') ) ): ?> The reverse order reads better to me. ($twitter_handle = get_the_author_meta('twitter')) != "" Do you even need the != ""? Empty string is false in PHP. Just the extra () should work. The mix of ' and " bothers me too.
Timothy Hatcher
Comment 3 2015-12-07 16:15:48 PST
Comment on attachment 266824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266824&action=review > Websites/webkit.org/wp-content/plugins/social-meta.php:14 > + $type = "article"; I forgot single vs double quotes have differences in PHP, unlike JS. These string here should likely be single quoted to match other static strings.
Jon Davis
Comment 4 2015-12-08 09:48:53 PST
Created attachment 266900 [details] Patch
Jon Davis
Comment 5 2015-12-08 11:38:06 PST
Created attachment 266919 [details] Patch
WebKit Commit Bot
Comment 6 2015-12-08 12:43:53 PST
Comment on attachment 266919 [details] Patch Clearing flags on attachment: 266919 Committed r193772: <http://trac.webkit.org/changeset/193772>
WebKit Commit Bot
Comment 7 2015-12-08 12:43:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.