Bug 151755 – AX: AXObjectCacheMac is passing WebCore enum values directly to VoiceOver

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Dominic Mazzoni]

As one example, in AXObjectCacheMac.mm when it's populating the userInfo dictionary to pass to AXPostNotificationWithUserInfo:

  [userInfo setObject:[NSNumber numberWithInt:intent.type] forKey:NSAccessibilityTextStateChangeTypeKey];

However, intent.type is of type AXTextStateChangeType, an enum defined in WebCore/accessibility/AXTextStateChangeIntent.h, and that numeric value is being passed directly to VoiceOver without any translation. As it is now, adding a new enum value to AXTextStateChangeType (in cross-platform code) would probably break WebKit on Mac.

In addition to separating the cross-platform constants from the Mac-specific constants, it'd be fantastic if you could document the protocol a bit more, since none of these keys appear in the 10.11 SDK or anywhere online yet.

Thanks.

[Radar WebKit Bug Importer]

<rdar://problem/23726751>

[Doug Russell]

Created attachment 268407 [details]
Patch

[chris fleizach]

Comment on attachment 268407 [details]
Patch

looks good

[WebKit Commit Bot]

Comment on attachment 268407 [details]
Patch

Clearing flags on attachment: 268407

Committed r194690: <http://trac.webkit.org/changeset/194690>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.