Bug 151748 - Polymorphic operand types for FTL mul.
Summary: Polymorphic operand types for FTL mul.
Status: RESOLVED DUPLICATE of bug 151746
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-02 09:17 PST by Mark Lam
Modified: 2015-12-02 12:53 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-12-02 09:17:28 PST 
Patch coming.
Comment 1 Radar WebKit Bug Importer 2015-12-02 09:18:40 PST 
<rdar://problem/23725315>
Comment 2 Mark Lam 2015-12-02 12:53:10 PST 
Will implement the DFG and FTL bits in one go in https://bugs.webkit.org/show_bug.cgi?id=151746 instead.

This is because there are perf tests (in JSRegress) that will show a regression if we implement only the DFG part first.  The perceived regression is not actually due to the polymorphic mul under-performing, but rather due to the FTL not being able to compile the test function if we don't already support polymorphic mul in the FTL.  The mul operator is in a code path that doesn't actually gets exercised by the tests, but the FTL makes the rest of the function runs much faster.  Without the FTL, the test function runs slower due to no fault of the mul operator, other than its presence making the function not compilable by the FTL.

By implementing DFG and FTL support in one go, we avoid this issue altogether.

*** This bug has been marked as a duplicate of bug 151746 ***