It is no longer ever used by WebKit2. Simplify the WebKit/WebCore interface.
<rdar://problem/23723158>
Created attachment 266437 [details] patch
Attachment 266437 [details] did not pass style-queue: ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 266438 [details] patch
Attachment 266438 [details] did not pass style-queue: ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 266440 [details] patch
Attachment 266440 [details] did not pass style-queue: ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 266456 [details] patch
Attachment 266456 [details] did not pass style-queue: ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 266456 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=266456&action=review r=me with comments. > Source/WebCore/platform/PlatformStrategies.h:90 > + CookiesStrategy* m_cookiesStrategy { }; Is this the cool new way to say { nullptr }? > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:294 > + NetworkResourceLoadParameters loadParameters; defersLoading, needsCertificateInfo, and maximumBufferingTime seem to be uninitialized. > Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:92 > LoaderStrategy* WebPlatformStrategies::createLoaderStrategy() These could probably be made to return references. > Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:64 > + return static_cast<WebResourceLoadScheduler&>(*platformStrategies()->loaderStrategy()); Why is it ok to dereference this pointer? I think this should be done differently.
I'll do further cleanups separately.
Created attachment 266525 [details] patch
Attachment 266525 [details] did not pass style-queue: ERROR: Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.cpp:25: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/CMakeLists.txt:6: Alphabetical sorting problem. "WebCoreSupport/WebResourceLoadScheduler.cpp" should be before "WebCoreSupport/WebViewGroup.cpp". [list/order] [5] Total errors found: 2 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
https://trac.webkit.org/r192995