Bug 151740 – Update JSC feature list for rest parameters and generators

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 266812 [details]
patch

[Joseph Pecoraro]

Comment on attachment 266812 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266812&action=review

r=me

> Source/JavaScriptCore/features.json:132
>              "status": "In Development",
> -            "enabled-by-default": false
> +            "enabled-by-default": true

Should this be "Done" or is it still in development?

> Source/JavaScriptCore/features.json:230
> +        "name": "Rest Parameter",

Should this be plural? Sometimes it is and isn't, but I think most of the time I've seen it pluralized.

[Saam Barati]

Comment on attachment 266812 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266812&action=review

>> Source/JavaScriptCore/features.json:132
>> +            "enabled-by-default": true
> 
> Should this be "Done" or is it still in development?

It's still under active development but it also works.
I think In Development is an okay name.

>> Source/JavaScriptCore/features.json:230
>> +        "name": "Rest Parameter",
> 
> Should this be plural? Sometimes it is and isn't, but I think most of the time I've seen it pluralized.

I've seen it both ways too.
It doesn't help that the title of of this page on MDN is "rest parameters" and the first sentence starts with "the rest parameter" (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/rest_parameters).
I think singular is more correct because it is a single parameter that gathers an array of the rest of the arguments.

[WebKit Commit Bot]

Comment on attachment 266812 [details]
patch

Clearing flags on attachment: 266812

Committed r193659: <http://trac.webkit.org/changeset/193659>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.