Bug 151732 – Modern IDB: storage/indexeddb/exceptions.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: storage/indexeddb/ fails

[Brady Eidson]

Modern IDB: storage/indexeddb/exceptions.html fails

[Brady Eidson]

Fixing this will require making many more IDLs be "RaisesExceptionWithMessage", and then adding lots of messages.

[Brady Eidson]

The test also caught a couple of very real violations of the spec.

[Brady Eidson]

Created attachment 266572 [details]
Patch v1

[Alex Christensen]

Comment on attachment 266572 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=266572&action=review

Probably all the test expectations changes should be in platform/wk1 for now.
r=me
Hooray messages!

> Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:154
> +            return 0;

nullptr

[Build Bot]

Comment on attachment 266572 [details]
Patch v1

Attachment 266572 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/513187

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 266576 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 266572 [details]
Patch v1

Attachment 266572 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/513177

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 266577 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 266572 [details]
Patch v1

Attachment 266572 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/513191

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 266578 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Brady Eidson]

Created attachment 266629 [details]
Patch for EWS and then maybe landing v1

[Brady Eidson]

Created attachment 266630 [details]
Patch for eWS and then maybe landing v1

[Brady Eidson]

Yay for successful EWS.

CQ+'ing

[WebKit Commit Bot]

Comment on attachment 266630 [details]
Patch for eWS and then maybe landing v1

Clearing flags on attachment: 266630

Committed r193428: <http://trac.webkit.org/changeset/193428>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.