Bug 151731 - Modern IDB: storage/indexeddb/cursor-advance.html fails
Summary: Modern IDB: storage/indexeddb/cursor-advance.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 151807
Blocks: 149117 150882
  Show dependency tree / graph
 
Reported: 2015-12-01 16:45 PST by Brady Eidson
Modified: 2015-12-03 12:07 PST (History)
8 users (show)

See Also:

Attachments
Patch v1 (13.32 KB, patch)
2015-12-01 16:54 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 (13.32 KB, patch)
2015-12-01 17:00 PST, Brady Eidson 		beidson: review-
beidson: commit-queue-
Details | Formatted Diff | Diff
Patch v3 (15.36 KB, patch)
2015-12-03 11:12 PST, Brady Eidson 		achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (15.92 KB, patch)
2015-12-03 11:35 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-12-01 16:45:46 PST 
Modern IDB: storage/indexeddb/cursor-advance.html fails

It expects detailed error messages on the exceptions that are thrown.

One of them we can match exactly.

The others we'll give a good message for and then update the test results.
Comment 1 Brady Eidson 2015-12-01 16:54:45 PST 
Created attachment 266411 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-12-01 16:55:30 PST 
Attachment 266411 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBinding.cpp:245:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2015-12-01 17:00:22 PST 
Created attachment 266412 [details]
Patch v2
Comment 4 Brady Eidson 2015-12-03 11:12:30 PST 
Created attachment 266537 [details]
Patch v3
Comment 5 Alex Christensen 2015-12-03 11:24:23 PST 
Comment on attachment 266537 [details]
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=266537&action=review

r=me with one comment.

> Source/WebCore/bindings/js/JSDOMBinding.cpp:226
> +static JSValue createDOMException(ExecState* exec, ExceptionCode ec, const String& message)

Less duplicate code.  Share with the original createDOMException.
Comment 6 Brady Eidson 2015-12-03 11:35:41 PST 
Created attachment 266539 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2015-12-03 12:07:16 PST 
Comment on attachment 266539 [details]
Patch for landing

Clearing flags on attachment: 266539

Committed r193364: <http://trac.webkit.org/changeset/193364>
Comment 8 WebKit Commit Bot 2015-12-03 12:07:20 PST 
All reviewed patches have been landed.  Closing bug.