RESOLVED FIXED 151721
[Win] Run non-http tests without Cygwin 
https://bugs.webkit.org/show_bug.cgi?id=151721
Summary [Win] Run non-http tests without Cygwin
Brent Fulgham
Reported 2015-12-01 14:13:21 PST
The attached patch allows you to run the WebKit LayoutTest suite without needing Cygwin. It does not yet support HTTP tests.
Attachments
Patch (52.36 KB, patch)
2015-12-01 16:39 PST, Brent Fulgham 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-12-01 16:39:15 PST
Created attachment 266409 [details] Patch
WebKit Commit Bot
Comment 2 2015-12-01 16:42:06 PST
Attachment 266409 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/port/win.py:231: [WinPort.read_registry_value] Undefined variable 'WindowsError' [pylint/E0602] [5] ERROR: Tools/Scripts/webkitpy/port/win.py:257: [WinPort.write_registry_value] Undefined variable 'WindowsError' [pylint/E0602] [5] ERROR: Tools/Scripts/webkitpy/port/win.py:261: [WinPort.write_registry_value] Undefined variable 'WindowsError' [pylint/E0602] [5] Total errors found: 3 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 3 2015-12-01 16:42:52 PST
(In reply to comment #2) > Attachment 266409 [details] did not pass style-queue: > > > ERROR: Tools/Scripts/webkitpy/port/win.py:231: > [WinPort.read_registry_value] Undefined variable 'WindowsError' > [pylint/E0602] [5] > ERROR: Tools/Scripts/webkitpy/port/win.py:257: > [WinPort.write_registry_value] Undefined variable 'WindowsError' > [pylint/E0602] [5] > ERROR: Tools/Scripts/webkitpy/port/win.py:261: > [WinPort.write_registry_value] Undefined variable 'WindowsError' > [pylint/E0602] [5] > Total errors found: 3 in 24 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. These warnings are false positives. WindowsError is present in the native Windows Python implementation.
Andy Estes
Comment 4 2015-12-01 18:15:01 PST
Comment on attachment 266409 [details] Patch rs=me
Brent Fulgham
Comment 5 2015-12-02 08:53:23 PST
Committed r192944: <http://trac.webkit.org/changeset/192944>
Note You need to log in before you can comment on or make changes to this bug.