Patch forthcoming.
Created attachment 266381 [details] work in progress
Created attachment 266426 [details] might be done
Created attachment 266476 [details] a bit more
Created attachment 266480 [details] wow it compiles!
Created attachment 266502 [details] it ran a program
Comment on attachment 266502 [details] it ran a program Ooops, not meant to be r?
Comment on attachment 266502 [details] it ran a program This is starting to work.
Attachment 266502 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOSRExitHandle.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:242: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9326: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:92: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:117: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:122: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 6 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 266502 [details] it ran a program Attachment 266502 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/509425 Number of test failures exceeded the failure limit.
Created attachment 266503 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 266502 [details] it ran a program Attachment 266502 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/509427 Number of test failures exceeded the failure limit.
Created attachment 266504 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 266502 [details] it ran a program Attachment 266502 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/509424 Number of test failures exceeded the failure limit.
Created attachment 266506 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 266513 [details] the patch
Attachment 266513 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOSRExitHandle.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:242: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9380: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:92: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:117: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:122: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 6 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 266513 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=266513&action=review r=me with a naming suggestion > Source/JavaScriptCore/ftl/FTLOSRExit.h:114 > + RefPtr<OSRExitHandle> appendOSRExit( To me the append* names here read a bit weird. To me it would make more sense to just call them emitOSRExit and emitOSRExitLater.
Comment on attachment 266513 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=266513&action=review >> Source/JavaScriptCore/ftl/FTLOSRExit.h:114 >> + RefPtr<OSRExitHandle> appendOSRExit( > > To me the append* names here read a bit weird. > To me it would make more sense to just call them emitOSRExit and emitOSRExitLater. I can dig it.
Landed in http://trac.webkit.org/changeset/193362