Bug 151699 - REGRESSION(r192834): [GTK] Test /webkit2/WebKitWebView/editor-state/typing-attributes times out after r192834
Summary: REGRESSION(r192834): [GTK] Test /webkit2/WebKitWebView/editor-state/typing-at...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2015-12-01 01:33 PST by Carlos Garcia Campos
Modified: 2015-12-01 09:40 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2015-12-01 01:35 PST, Carlos Garcia Campos 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-12-01 01:33:04 PST 
We are no longer notified of the editor state change from WebPage::didChangeSelection(), the non mac code was removed in r192834.
Comment 1 Carlos Garcia Campos 2015-12-01 01:35:35 PST 
Created attachment 266347 [details]
Patch

The fix is pretty obvious, but I'm assuming it was removed by mistake, so better get a review to be sure.
Comment 2 Carlos Garcia Campos 2015-12-01 09:40:50 PST 
Committed r192888: <http://trac.webkit.org/changeset/192888>