Bug 151698 - [Win] Small caps on web fonts have excess whitespace with the complex text code path
Summary: [Win] Small caps on web fonts have excess whitespace with the complex text co...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on: 151738
Blocks: 149773
  Show dependency tree / graph
 
Reported: 2015-12-01 00:33 PST by Myles C. Maxfield
Modified: 2015-12-01 19:57 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.32 KB, patch)
2015-12-01 00:40 PST, Myles C. Maxfield 		darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (909.31 KB, application/zip)
2015-12-01 01:25 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (815.52 KB, application/zip)
2015-12-01 01:29 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (802.77 KB, application/zip)
2015-12-01 03:32 PST, Build Bot 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-12-01 00:33:13 PST 
[Win] Small caps have excess whitespace with the complex text codepath
Comment 1 Myles C. Maxfield 2015-12-01 00:40:22 PST 
Created attachment 266341 [details]
Patch
Comment 2 Myles C. Maxfield 2015-12-01 00:45:22 PST 
Comment on attachment 266341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266341&action=review

> Source/WebCore/ChangeLog:3
> +        [Win] Small caps have excess whitespace with the complex text codepath

Mention that this is only a problem for web fonts.
Comment 3 Build Bot 2015-12-01 01:25:48 PST 
Comment on attachment 266341 [details]
Patch

Attachment 266341 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/500770

New failing tests:
fast/text/small-caps-complex.html
Comment 4 Build Bot 2015-12-01 01:25:50 PST 
Created attachment 266344 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2015-12-01 01:29:11 PST 
Comment on attachment 266341 [details]
Patch

Attachment 266341 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/500772

New failing tests:
fast/text/small-caps-complex.html
Comment 6 Build Bot 2015-12-01 01:29:14 PST 
Created attachment 266345 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2015-12-01 03:32:29 PST 
Comment on attachment 266341 [details]
Patch

Attachment 266341 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/501125

New failing tests:
fast/text/small-caps-complex.html
Comment 8 Build Bot 2015-12-01 03:32:31 PST 
Created attachment 266351 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Myles C. Maxfield 2015-12-01 11:10:21 PST 
Committed r192894: <http://trac.webkit.org/changeset/192894>
Comment 10 Myles C. Maxfield 2015-12-01 16:28:46 PST 
It seems that this is crashy :(
Comment 11 Myles C. Maxfield 2015-12-01 19:19:57 PST 
Build fix in r192904
Comment 12 WebKit Commit Bot 2015-12-01 19:21:20 PST 
Re-opened since this is blocked by bug 151738
Comment 13 Myles C. Maxfield 2015-12-01 19:57:37 PST 
Somewhat related: https://bugs.webkit.org/show_bug.cgi?id=151651