Bug 151690 - [iOS] Adjacent emoji overlap each other
Summary: [iOS] Adjacent emoji overlap each other
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-30 18:06 PST by Myles C. Maxfield
Modified: 2015-12-02 02:47 PST (History)
7 users (show)

See Also:

Attachments
Patch (24.51 KB, patch)
2015-11-30 18:16 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (24.57 KB, patch)
2015-11-30 18:18 PST, Myles C. Maxfield 		simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-yosemite (1003.39 KB, application/zip)
2015-11-30 19:11 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (1022.35 KB, application/zip)
2015-11-30 19:12 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (932.73 KB, application/zip)
2015-11-30 19:16 PST, Build Bot 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-11-30 18:06:45 PST 
[iOS] Adjacent emoji overlap each other
Comment 1 Myles C. Maxfield 2015-11-30 18:16:54 PST 
Created attachment 266315 [details]
Patch
Comment 2 Myles C. Maxfield 2015-11-30 18:17:35 PST 
<rdar://problem/23430453>
Comment 3 Myles C. Maxfield 2015-11-30 18:18:16 PST 
Created attachment 266316 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-11-30 18:39:18 PST 
Comment on attachment 266316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266316&action=review

> Source/WebCore/ChangeLog:16
> +        This patch also performs a little bit of cleanup by moving Font's m_isSystemFont
> +        to FontPlatformData where it belongs.

Would have been nice to do that in a separate patch. In fact, I would still advise this.

> Source/WebCore/platform/graphics/FontPlatformData.h:194
> +#if PLATFORM(IOS)
> +        return m_isEmoji;
> +#else
> +        return false;
> +#endif

Emoji exist on Mac. Why do we need the #ifdef?
Comment 5 Build Bot 2015-11-30 19:11:37 PST 
Comment on attachment 266316 [details]
Patch

Attachment 266316 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/499452

New failing tests:
fast/text/emoji-overlap.html
Comment 6 Build Bot 2015-11-30 19:11:39 PST 
Created attachment 266321 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2015-11-30 19:12:56 PST 
Comment on attachment 266316 [details]
Patch

Attachment 266316 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/499477

New failing tests:
fast/text/emoji-overlap.html
Comment 8 Build Bot 2015-11-30 19:12:58 PST 
Created attachment 266322 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2015-11-30 19:16:55 PST 
Comment on attachment 266316 [details]
Patch

Attachment 266316 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/499480

New failing tests:
fast/text/emoji-overlap.html
Comment 10 Build Bot 2015-11-30 19:16:57 PST 
Created attachment 266323 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 11 Myles C. Maxfield 2015-12-01 11:25:09 PST 
Committed r192895: <http://trac.webkit.org/changeset/192895>
Comment 12 Myles C. Maxfield 2015-12-01 11:38:17 PST 
Comment on attachment 266316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266316&action=review

>> Source/WebCore/platform/graphics/FontPlatformData.h:194
>> +#endif
> 
> Emoji exist on Mac. Why do we need the #ifdef?

CG only returns bogus information on iOS. On OS X it works correctly.
Comment 13 Csaba Osztrogonác 2015-12-01 13:56:24 PST 
(In reply to comment #11)
> Committed r192895: <http://trac.webkit.org/changeset/192895>

It broke the Apple Windows build.
Comment 14 Myles C. Maxfield 2015-12-01 15:28:28 PST 
(In reply to comment #13)
> (In reply to comment #11)
> > Committed r192895: <http://trac.webkit.org/changeset/192895>
> 
> It broke the Apple Windows build.

Fixed in http://trac.webkit.org/changeset/192917
Comment 15 Myles C. Maxfield 2015-12-01 19:56:34 PST 
Windows test fix in http://trac.webkit.org/changeset/192940
Comment 16 Csaba Osztrogonác 2015-12-02 02:47:55 PST 
and WinCairo build fixed by bug151742