Bug 151690 – [iOS] Adjacent emoji overlap each other

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[iOS] Adjacent emoji overlap each other

[Myles C. Maxfield]

Created attachment 266315 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/23430453>

[Myles C. Maxfield]

Created attachment 266316 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 266316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266316&action=review

> Source/WebCore/ChangeLog:16
> +        This patch also performs a little bit of cleanup by moving Font's m_isSystemFont
> +        to FontPlatformData where it belongs.

Would have been nice to do that in a separate patch. In fact, I would still advise this.

> Source/WebCore/platform/graphics/FontPlatformData.h:194
> +#if PLATFORM(IOS)
> +        return m_isEmoji;
> +#else
> +        return false;
> +#endif

Emoji exist on Mac. Why do we need the #ifdef?

[Build Bot]

Comment on attachment 266316 [details]
Patch

Attachment 266316 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/499452

New failing tests:
fast/text/emoji-overlap.html

[Build Bot]

Created attachment 266321 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 266316 [details]
Patch

Attachment 266316 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/499477

New failing tests:
fast/text/emoji-overlap.html

[Build Bot]

Created attachment 266322 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 266316 [details]
Patch

Attachment 266316 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/499480

New failing tests:
fast/text/emoji-overlap.html

[Build Bot]

Created attachment 266323 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Committed r192895: <http://trac.webkit.org/changeset/192895>

[Myles C. Maxfield]

Comment on attachment 266316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266316&action=review

>> Source/WebCore/platform/graphics/FontPlatformData.h:194
>> +#endif
> 
> Emoji exist on Mac. Why do we need the #ifdef?

CG only returns bogus information on iOS. On OS X it works correctly.

[Csaba Osztrogonác]

(In reply to comment #11)
> Committed r192895: <http://trac.webkit.org/changeset/192895>

It broke the Apple Windows build.

[Myles C. Maxfield]

(In reply to comment #13)
> (In reply to comment #11)
> > Committed r192895: <http://trac.webkit.org/changeset/192895>
> 
> It broke the Apple Windows build.

Fixed in http://trac.webkit.org/changeset/192917

[Myles C. Maxfield]

Windows test fix in http://trac.webkit.org/changeset/192940

[Csaba Osztrogonác]

and WinCairo build fixed by bug151742