Bug 151689 - Fix possible crash with animated layers in reflections
Summary: Fix possible crash with animated layers in reflections
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-30 17:38 PST by Simon Fraser (smfr)
Modified: 2015-11-30 18:47 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2015-11-30 17:40 PST, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-11-30 17:38:35 PST 
Fix possible crash with animated layers in reflections
Comment 1 Simon Fraser (smfr) 2015-11-30 17:40:09 PST 
Created attachment 266308 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-11-30 17:40:24 PST 
rdar://problem/23018612
Comment 3 Darin Adler 2015-11-30 17:57:09 PST 
Comment on attachment 266308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266308&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3501
> +    clearClonesOwner(m_layerClones.get());
>      m_layerClones = nullptr;

Since you are using a helper function, why not have it take std::unique_ptr<LayerMap>& and then it can do the nulling out too.
Comment 4 Simon Fraser (smfr) 2015-11-30 18:46:57 PST 
https://trac.webkit.org/changeset/192853