Bug 151687 - Add new library dependency for LLVMForJavaScriptCore dylib
Summary: Add new library dependency for LLVMForJavaScriptCore dylib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-30 17:19 PST by Juergen Ributzka
Modified: 2015-12-01 14:46 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2015-11-30 17:23 PST, Juergen Ributzka 		no flags Details | Formatted Diff | Diff
Patch (4.69 KB, patch)
2015-12-01 11:25 PST, Juergen Ributzka 		no flags Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2015-12-01 11:38 PST, Juergen Ributzka 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Juergen Ributzka 2015-11-30 17:19:16 PST 
Add new library dependency for LLVMForJavaScriptCore dylib
Comment 1 Juergen Ributzka 2015-11-30 17:23:59 PST 
Created attachment 266306 [details]
Patch
Comment 2 Mark Lam 2015-12-01 09:35:26 PST 
Comment on attachment 266306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266306&action=review

r=me

> Source/JavaScriptCore/ChangeLog:7
> +        Adding this dependency should be backwards compatible, since LLVM has build and

typo: build ==> built.
Comment 3 Geoffrey Garen 2015-12-01 09:49:48 PST 
Have you tested that this change builds successfully with new and old LLVM?
Comment 4 Juergen Ributzka 2015-12-01 10:24:37 PST 
Yes, I tried this with older LLVMs for iOS and OS X. The buildbots seems to be happy too and they are still using an older LLVM version.
Comment 5 Filip Pizlo 2015-12-01 11:17:45 PST 
Comment on attachment 266306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266306&action=review

> Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig:35
> -LLVM_LIBS_macosx   = -lLLVMLinker -lLLVMipo -lLLVMVectorize -lLLVMIRReader -lLLVMBitReader -lLLVMAsmParser -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMMCParser -lLLVMDebugInfo -lLLVMOption -lLLVMCodeGen -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMMCDisassembler -lLLVMMCJIT -lLLVMTarget -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport -lLLVMX86Disassembler     -lLLVMX86CodeGen     -lLLVMX86AsmParser     -lLLVMX86Desc     -lLLVMX86Info     -lLLVMX86AsmPrinter     -lLLVMX86Utils;
> +LLVM_LIBS_macosx   = -lLLVMInstrumentation -lLLVMLinker -lLLVMipo -lLLVMVectorize -lLLVMIRReader -lLLVMBitReader -lLLVMAsmParser -lLLVMSelectionDAG -lLLVMAsmPrinter -lLLVMMCParser -lLLVMDebugInfo -lLLVMOption -lLLVMCodeGen -lLLVMScalarOpts -lLLVMInstCombine -lLLVMTransformUtils -lLLVMipa -lLLVMAnalysis -lLLVMMCDisassembler -lLLVMMCJIT -lLLVMTarget -lLLVMRuntimeDyld -lLLVMExecutionEngine -lLLVMMC -lLLVMObject -lLLVMCore -lLLVMSupport -lLLVMX86Disassembler     -lLLVMX86CodeGen     -lLLVMX86AsmParser     -lLLVMX86Desc     -lLLVMX86Info     -lLLVMX86AsmPrinter     -lLLVMX86Utils;

Is this change necessary?
Comment 6 Juergen Ributzka 2015-12-01 11:20:24 PST 
Yes, this is a generic/target independent new dependency on this library.
Comment 7 Juergen Ributzka 2015-12-01 11:25:40 PST 
Created attachment 266370 [details]
Patch
Comment 8 Juergen Ributzka 2015-12-01 11:26:30 PST 
Fixed typo.
Comment 9 Juergen Ributzka 2015-12-01 11:38:34 PST 
Created attachment 266374 [details]
Patch
Comment 10 Juergen Ributzka 2015-12-01 11:39:09 PST 
Limit fix to iOS.
Comment 11 WebKit Commit Bot 2015-12-01 14:46:32 PST 
Comment on attachment 266374 [details]
Patch

Clearing flags on attachment: 266374

Committed r192918: <http://trac.webkit.org/changeset/192918>
Comment 12 WebKit Commit Bot 2015-12-01 14:46:35 PST 
All reviewed patches have been landed.  Closing bug.