Bug 151685 (CVE-2016-1778) - Fix anomaly where isMouseEvent returns false for wheel events
Summary: Fix anomaly where isMouseEvent returns false for wheel events
Status: RESOLVED FIXED
Alias: CVE-2016-1778
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-30 17:09 PST by Darin Adler
Modified: 2016-03-22 21:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.71 KB, patch)
2015-11-30 17:18 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-11-30 17:09:59 PST 
Fix anomaly where isMouseEvent returns false for wheel events
Comment 1 Darin Adler 2015-11-30 17:18:21 PST 
Created attachment 266305 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-11-30 22:21:37 PST 
Comment on attachment 266305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266305&action=review

> Source/WebCore/dom/WheelEvent.h:-94
> -    virtual bool isMouseEvent() const override;

Should we add "final" to the version in MouseEvent.h now?
Comment 3 Darin Adler 2015-12-01 10:23:30 PST 
Comment on attachment 266305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266305&action=review

>> Source/WebCore/dom/WheelEvent.h:-94
>> -    virtual bool isMouseEvent() const override;
> 
> Should we add "final" to the version in MouseEvent.h now?

Yes. I have a patch now that does a lot more to MouseEvent that I will land separately.
Comment 4 WebKit Commit Bot 2015-12-01 13:15:00 PST 
Comment on attachment 266305 [details]
Patch

Clearing flags on attachment: 266305

Committed r192903: <http://trac.webkit.org/changeset/192903>
Comment 5 WebKit Commit Bot 2015-12-01 13:15:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2015-12-01 14:27:45 PST 
Updated bindings test results in r192915 (EWS should run bindings tests!!!)
Comment 7 David Kilzer (:ddkilzer) 2015-12-01 15:02:01 PST 
<rdar://problem/23672418>
Comment 8 Brent Fulgham 2015-12-02 08:57:41 PST 
Comment on attachment 266305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266305&action=review

>>> Source/WebCore/dom/WheelEvent.h:-94
>>> -    virtual bool isMouseEvent() const override;
>> 
>> Should we add "final" to the version in MouseEvent.h now?
> 
> Yes. I have a patch now that does a lot more to MouseEvent that I will land separately.

I also thought we were dropping 'virtual' for 'override' methods, since this is redundant?
Comment 9 Darin Adler 2015-12-02 13:52:51 PST 
(In reply to comment #8)
> I also thought we were dropping 'virtual' for 'override' methods, since this
> is redundant?

Antti did propose that, and I spoke in favor of it, but I am not sure it’s settled. I have not seen a lot of patches doing that since that discussion.