Bug 151682 - CTTE autogenerated bindings code
Summary: CTTE autogenerated bindings code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-30 16:17 PST by Anders Carlsson
Modified: 2015-12-01 21:23 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.87 KB, patch)
2015-11-30 16:24 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (25.49 KB, patch)
2015-11-30 17:02 PST, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-11-30 16:17:55 PST 
CTTE autogenerated bindings code
Comment 1 Anders Carlsson 2015-11-30 16:24:06 PST 
Created attachment 266297 [details]
Patch
Comment 2 Anders Carlsson 2015-11-30 17:02:08 PST 
Created attachment 266303 [details]
Patch
Comment 3 Darin Adler 2015-11-30 17:31:44 PST 
Comment on attachment 266303 [details]
Patch

There is so much more of this to be done in CodeGeneratorJS.pm, such as passing ExecState as a reference to most helpers.
Comment 4 Anders Carlsson 2015-11-30 18:14:07 PST 
Committed r192849: <http://trac.webkit.org/changeset/192849>
Comment 5 Csaba Osztrogonác 2015-12-01 00:20:03 PST 
Just to document: It broke the EFL build (not in WebKit2 code!)
Unfortunately EWS didn't process this patch, because an other
Apple employee broke the build previously against the red EWS bubble.

And the fix landed in https://trac.webkit.org/changeset/192860
Comment 6 Csaba Osztrogonác 2015-12-01 00:21:26 PST 
And it broke the GTK build too as the EWS noticed it.
Comment 7 Csaba Osztrogonác 2015-12-01 01:59:36 PST 
(In reply to comment #6)
> And it broke the GTK build too as the EWS noticed it.

just to document, fix landed in https://trac.webkit.org/changeset/192872
Comment 8 Nikos Andronikos 2015-12-01 21:23:46 PST 
Also to document: This is causing the following type of error in the generated Objective-C code for partial interfaces:

webkit/WebKitBuild/Debug/DerivedSources/WebCore/DOMDocument.mm:443:65: error: non-const lvalue reference to type 'WebCore::Document' cannot bind to a temporary of type 'WebCore::Document *'
    return kit(WTF::getPtr(WebCore::DocumentAnimation::timeline(IMPL)));
                                                                ^~~~
webkit/WebKitBuild/Debug/DerivedSources/WebCore/DOMDocument.mm:106:14: note: expanded from macro 'IMPL'
#define IMPL static_cast<WebCore::Document*>(reinterpret_cast<WebCore::Node*>(_internal))

See bug 151739 for patch