Bug 151670 - Fix the graphics benchmark complexity bounds adjustment
Summary: Fix the graphics benchmark complexity bounds adjustment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-30 12:45 PST by Said Abou-Hallawa
Modified: 2015-11-30 15:06 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2015-11-30 12:49 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-11-30 12:45:34 PST
The test complexity bounds (min-max values) are used to prevent the test FPS from fluctuating. We always make sure the current complexity of the test is within these bounds. These bounds are the min-max values of the test complexity starting from the beginning of the first overshoot till the end of the following undershoot of the FPS.

We need also to make sure that the bounds are large enough to allow some flexibility. This is helpful when the difference between the lower and upper bounds is very small. I think it is enough to make sure the lower bound is at least 90% of the upper bound. The bounds are negative in the case of graphics benchmark since the relationship between the test complexity and FPS is reverse proportional. So we need to apply the adjustment to the "absolute" minimum bound which is (min if min < 0) or (max if max < 0).
Comment 1 Said Abou-Hallawa 2015-11-30 12:49:03 PST
Created attachment 266261 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-30 15:06:43 PST
Comment on attachment 266261 [details]
Patch

Clearing flags on attachment: 266261

Committed r192835: <http://trac.webkit.org/changeset/192835>
Comment 3 WebKit Commit Bot 2015-11-30 15:06:46 PST
All reviewed patches have been landed.  Closing bug.