Bug 151667 - FTL lazy slow paths should work with B3
Summary: FTL lazy slow paths should work with B3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 151668
Blocks: 150279
  Show dependency treegraph
 
Reported: 2015-11-30 12:08 PST by Filip Pizlo
Modified: 2020-07-03 12:43 PDT (History)
14 users (show)

See Also:


Attachments
work in progress (18.38 KB, patch)
2015-11-30 17:56 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
it compiles! (22.43 KB, patch)
2015-11-30 19:01 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (25.79 KB, patch)
2015-11-30 19:37 PST, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-11-30 12:08:14 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2015-11-30 17:56:40 PST
Created attachment 266310 [details]
work in progress

I haven't tried compiling it yet.
Comment 2 Filip Pizlo 2015-11-30 19:01:11 PST
Created attachment 266319 [details]
it compiles!
Comment 3 Filip Pizlo 2015-11-30 19:37:59 PST
Created attachment 266326 [details]
the patch
Comment 4 Filip Pizlo 2015-11-30 19:38:54 PST
Oh man, I'm playing the EWS lottery so hard - I haven't tested this with FTL_USES_B3 disabled.
Comment 5 WebKit Commit Bot 2015-11-30 19:39:48 PST
Attachment 266326 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7853:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7870:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7887:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Geoffrey Garen 2015-11-30 19:43:19 PST
Comment on attachment 266326 [details]
the patch

r=me
Comment 7 Filip Pizlo 2015-11-30 20:43:58 PST
Landed in http://trac.webkit.org/changeset/192856