Bug 151662 – Make ProcessModel always MultipleSecondaryProcesses

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Make ProcessModel always MultipleSecondaryProcesses

[Alex Christensen]

Created attachment 266250 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 266250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266250&action=review

> Source/WebKit2/UIProcess/API/C/WKContext.h:78
> +// FIXME: Remove these once support for Mavericks has been dropped.

Doesn't https://trac.webkit.org/changeset/192706 mean that Apple already dropped Mavericks support?
I thought that only the two latest relases are supported, they are Yosemite and El Capitan.

[Antti Koivisto]

Comment on attachment 266250 [details]
Patch

Nice! r=me

[Antti Koivisto]

Comment on attachment 266250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266250&action=review

> Source/WebKit2/UIProcess/WebProcessPool.cpp:1106
>  void WebProcessPool::requestWebContentStatistics(StatisticsRequest* request)
>  {
> -    if (processModel() == ProcessModelSharedSecondaryProcess) {
> -        if (m_processes.isEmpty())
> -            return;
> -        
> -        uint64_t requestID = request->addOutstandingRequest();
> -        m_statisticsRequests.set(requestID, request);
> -        m_processes[0]->send(Messages::WebProcess::GetWebCoreStatistics(requestID), 0);
> -
> -    } else {
> -        // FIXME (Multi-WebProcess) <rdar://problem/13200059>: Make getting statistics from multiple WebProcesses work.
> -    }
> +    // FIXME (Multi-WebProcess) <rdar://problem/13200059>: Make getting statistics from multiple WebProcesses work.
>  }

Maybe we should just remove this stuff entirely?

[Alex Christensen]

(In reply to comment #3)
> Doesn't https://trac.webkit.org/changeset/192706 mean that Apple already dropped Mavericks support?
Probably.  I'll double check that removing the things doesn't break compiling then move the things.
(In reply to comment #4)
> Comment on attachment 266250 [details]
> Patch
> > +    // FIXME (Multi-WebProcess) <rdar://problem/13200059>: Make getting statistics from multiple WebProcesses work.
> >  }
> 
> Maybe we should just remove this stuff entirely?
Probably.  We can probably remove a whole bunch more code.

http://trac.webkit.org/changeset/192808
More code removal can be done in other patches.