Bug 151656 – [EFL] Implement scheduleTimer and cancelTimer in IncrementalSweeper class

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gyuyoung Kim]

As mac and gtk ports, EFL ports supports IncremntalSweeper using Ecore_Timer.

[Gyuyoung Kim]

Created attachment 266246 [details]
Patch

[Gyuyoung Kim]

Created attachment 266340 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 266340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266340&action=review

> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:79
> +    if (m_isTimerFrozen) {

I couldn't find an EFL function to check if timer is frozen. If there is any function to check it, please let me know.

[Gyuyoung Kim]

Created attachment 266434 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 266434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266434&action=review

LGTM, r=me with some comments.

> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:47
> -#if USE(CF) || (USE(GLIB) && !PLATFORM(EFL))
> +#if USE(CF) || USE(GLIB)

I know that USE(GLIB) is true for us too, but it is a little bit
confusing to rely on USE(GLIB) when we don't use GLIB timer here.

I suggest using "#if USE(CF) || PLATFORM(EFL) || USE(GLIB)".
It is redundant, but more descriptive and less confusing.

> Source/JavaScriptCore/heap/IncrementalSweeper.h:52
> -#if USE(CF) || (USE(GLIB) && !PLATFORM(EFL))
> +#if USE(CF) || USE(GLIB)

ditto

[Gyuyoung Kim]

Created attachment 266766 [details]
Patch for landing

[Gyuyoung Kim]

Comment on attachment 266434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266434&action=review

>> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:47
>> +#if USE(CF) || USE(GLIB)
> 
> I know that USE(GLIB) is true for us too, but it is a little bit
> confusing to rely on USE(GLIB) when we don't use GLIB timer here.
> 
> I suggest using "#if USE(CF) || PLATFORM(EFL) || USE(GLIB)".
> It is redundant, but more descriptive and less confusing.

Agreed.

[WebKit Commit Bot]

Comment on attachment 266766 [details]
Patch for landing

Clearing flags on attachment: 266766

Committed r193627: <http://trac.webkit.org/changeset/193627>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.