Bug 151647 - Modern IDB: Support updating cursor values when the object store uses inline keys
Summary: Modern IDB: Support updating cursor values when the object store uses inline ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 150882
  Show dependency tree / graph
 
Reported: 2015-11-29 11:41 PST by Brady Eidson
Modified: 2015-11-30 11:05 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (8.29 KB, patch)
2015-11-29 11:44 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v1 (applies) (8.36 KB, patch)
2015-11-30 10:30 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v1 (really applies) (8.37 KB, patch)
2015-11-30 10:39 PST, Brady Eidson 		aestes: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-11-29 11:41:46 PST 
Modern IDB: Support updating cursor values when the object store uses inline keys
Comment 1 Brady Eidson 2015-11-29 11:44:25 PST 
Created attachment 266226 [details]
Patch v1
Comment 2 Brady Eidson 2015-11-29 11:47:25 PST 
Comment on attachment 266226 [details]
Patch v1

This one relies on at least one of the other patches I have waiting in review, so unmarking for review at this time.
Comment 3 Brady Eidson 2015-11-30 10:30:29 PST 
Created attachment 266249 [details]
Patch v1 (applies)
Comment 4 Brady Eidson 2015-11-30 10:35:40 PST 
Well, apparently this doesn't apply, even though I just made it from trunk!

Other stuff have probably landed since I updated.
Comment 5 Brady Eidson 2015-11-30 10:39:07 PST 
Created attachment 266252 [details]
Patch v1 (really applies)
Comment 6 Andy Estes 2015-11-30 10:43:16 PST 
Comment on attachment 266252 [details]
Patch v1 (really applies)

View in context: https://bugs.webkit.org/attachment.cgi?id=266252&action=review

> Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp:228
> +    auto idbKey = scriptValueToIDBKey(state, key);

You don't need to use a local variable here.
Comment 7 Brady Eidson 2015-11-30 11:05:31 PST 
https://trac.webkit.org/changeset/192806