Bug 151645 - Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest
Summary: Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 150882
  Show dependency tree / graph
 
Reported: 2015-11-28 23:10 PST by Brady Eidson
Modified: 2015-11-30 10:24 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (5.35 KB, patch)
2015-11-29 09:53 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-11-28 23:10:24 PST 
Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest

IDBRequest::hasPendingActivity() lies for IDBOpenDBRequests that have fired their onUpgradeNeeded event but not yet fired their onSuccess event.

GC can happen between, removing the wrapper, and therefore causing onSuccess to never actually fire.
Comment 1 Brady Eidson 2015-11-29 09:53:03 PST 
Created attachment 266223 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-11-30 10:24:37 PST 
Comment on attachment 266223 [details]
Patch v1

Clearing flags on attachment: 266223

Committed r192803: <http://trac.webkit.org/changeset/192803>
Comment 3 WebKit Commit Bot 2015-11-30 10:24:41 PST 
All reviewed patches have been landed.  Closing bug.