RESOLVED FIXED Bug 151640
Modern IDB: Support keyPath injection into object store records 
https://bugs.webkit.org/show_bug.cgi?id=151640
Summary Modern IDB: Support keyPath injection into object store records
Brady Eidson
Reported 2015-11-27 22:17:15 PST
Modern IDB: Support keyPath injection into object store records
Attachments
Patch v1 (17.37 KB, patch)
2015-11-29 10:22 PST, Brady Eidson 		aestes: review+
aestes: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-11-29 10:22:28 PST
Created attachment 266225 [details] Patch v1
Andy Estes
Comment 2 2015-11-30 09:32:47 PST
Comment on attachment 266225 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=266225&action=review > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:488 > + static NeverDestroyed<RefPtr<VM>> vm = VM::create(); Anders once asked me to not use NeverDestroyed for heap-allocated objects. You can just use a static VM* and leak the reference. > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:495 > + static NeverDestroyed<Strong<JSGlobalObject>> globalObject; LazyNeverDestroyed? > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:568 > + RefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(&databaseThreadExecState(), value, nullptr, nullptr); You can use auto here.
Brady Eidson
Comment 3 2015-11-30 10:16:38 PST
https://trac.webkit.org/changeset/192798
Note You need to log in before you can comment on or make changes to this bug.