Bug 151620 – Fix the ENABLE(B3_JIT) build with GCC in B3Procedure.h

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Csaba Osztrogonác]

build log:
-----------
In file included from /usr/include/c++/4.9/memory:81:0,
                 from ../../Source/WTF/wtf/StdLibExtras.h:31,
                 from ../../Source/WTF/wtf/FastMalloc.h:26,
                 from ../../Source/JavaScriptCore/config.h:54,
                 from ../../Source/JavaScriptCore/b3/B3LowerMacros.cpp:26:
/usr/include/c++/4.9/bits/unique_ptr.h: In instantiation of 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = JSC::B3::OpaqueByproducts]':
/usr/include/c++/4.9/bits/unique_ptr.h:236:16:   required from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = JSC::B3::OpaqueByproducts; _Dp = std::default_delete<JSC::B3::OpaqueByproducts>]'
../../Source/JavaScriptCore/b3/B3Procedure.h:222:87:   required from here
/usr/include/c++/4.9/bits/unique_ptr.h:74:22: error: invalid application of 'sizeof' to incomplete type 'JSC::B3::OpaqueByproducts'
ninja: build stopped: subcommand failed.

[Csaba Osztrogonác]

Created attachment 266180 [details]
Patch

[Mark Lam]

Comment on attachment 266180 [details]
Patch

I don't see any use of OpaqueByproducts in B3Procedure.h other than as a pointer.  Which files are failing to build without this change?  Should they be #including B3OpaqueByproducts.h themselves?

[Csaba Osztrogonác]

(In reply to comment #2)
> Comment on attachment 266180 [details]
> Patch
> 
> I don't see any use of OpaqueByproducts in B3Procedure.h other than as a
> pointer.  Which files are failing to build without this change?  Should they
> be #including B3OpaqueByproducts.h themselves?

I got the cited error for almost all cpp files. I don't think 
if we should include this header everywhere explicitly.

[Mark Lam]

Comment on attachment 266180 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 266180 [details]
Patch

Clearing flags on attachment: 266180

Committed r192777: <http://trac.webkit.org/changeset/192777>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.