Bug 151620 - Fix the ENABLE(B3_JIT) build with GCC in B3Procedure.h
Summary: Fix the ENABLE(B3_JIT) build with GCC in B3Procedure.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 152248
  Show dependency tree / graph
 
Reported: 2015-11-26 05:35 PST by Csaba Osztrogonác
Modified: 2015-12-14 04:56 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2015-11-26 05:38 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-11-26 05:35:36 PST 
build log:
-----------
In file included from /usr/include/c++/4.9/memory:81:0,
                 from ../../Source/WTF/wtf/StdLibExtras.h:31,
                 from ../../Source/WTF/wtf/FastMalloc.h:26,
                 from ../../Source/JavaScriptCore/config.h:54,
                 from ../../Source/JavaScriptCore/b3/B3LowerMacros.cpp:26:
/usr/include/c++/4.9/bits/unique_ptr.h: In instantiation of 'void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = JSC::B3::OpaqueByproducts]':
/usr/include/c++/4.9/bits/unique_ptr.h:236:16:   required from 'std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = JSC::B3::OpaqueByproducts; _Dp = std::default_delete<JSC::B3::OpaqueByproducts>]'
../../Source/JavaScriptCore/b3/B3Procedure.h:222:87:   required from here
/usr/include/c++/4.9/bits/unique_ptr.h:74:22: error: invalid application of 'sizeof' to incomplete type 'JSC::B3::OpaqueByproducts'
ninja: build stopped: subcommand failed.
Comment 1 Csaba Osztrogonác 2015-11-26 05:38:40 PST 
Created attachment 266180 [details]
Patch
Comment 2 Mark Lam 2015-11-26 06:50:25 PST 
Comment on attachment 266180 [details]
Patch

I don't see any use of OpaqueByproducts in B3Procedure.h other than as a pointer.  Which files are failing to build without this change?  Should they be #including B3OpaqueByproducts.h themselves?
Comment 3 Csaba Osztrogonác 2015-11-26 07:03:34 PST 
(In reply to comment #2)
> Comment on attachment 266180 [details]
> Patch
> 
> I don't see any use of OpaqueByproducts in B3Procedure.h other than as a
> pointer.  Which files are failing to build without this change?  Should they
> be #including B3OpaqueByproducts.h themselves?

I got the cited error for almost all cpp files. I don't think 
if we should include this header everywhere explicitly.
Comment 4 Mark Lam 2015-11-26 07:04:35 PST 
Comment on attachment 266180 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2015-11-27 05:01:31 PST 
Comment on attachment 266180 [details]
Patch

Clearing flags on attachment: 266180

Committed r192777: <http://trac.webkit.org/changeset/192777>
Comment 6 WebKit Commit Bot 2015-11-27 05:01:36 PST 
All reviewed patches have been landed.  Closing bug.