Bug 151569 - [Win] Implement methods to get and set inner html.
Summary: [Win] Implement methods to get and set inner html.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-23 11:13 PST by peavo
Modified: 2015-11-24 00:41 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2015-11-23 11:19 PST, peavo
no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2015-11-23 11:30 PST, peavo
achristensen: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (804.83 KB, application/zip)
2015-11-23 12:22 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-11-23 11:13:55 PST
DOMHTMLElement::innerHTML and DOMHTMLElement::setInnerHTML are not implemented on Windows yet.
Comment 1 peavo 2015-11-23 11:19:08 PST
Created attachment 266092 [details]
Patch
Comment 2 peavo 2015-11-23 11:30:04 PST
Created attachment 266093 [details]
Patch
Comment 3 Build Bot 2015-11-23 12:22:03 PST
Comment on attachment 266093 [details]
Patch

Attachment 266093 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/468549

New failing tests:
js/property-name-enumerator-gc-151495.html
Comment 4 Build Bot 2015-11-23 12:22:05 PST
Created attachment 266094 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Alex Christensen 2015-11-23 14:22:17 PST
Comment on attachment 266093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266093&action=review

This looks a lot like the innerText implementation just below it :)
r=me, mac test failures unrelated.

> Source/WebKit/win/DOMHTMLClasses.cpp:507
> +    String innerHtmlString = downcast<HTMLElement>(m_element)->innerHTML();

innerHTMLString

> Source/WebKit/win/DOMHTMLClasses.cpp:515
> +    HTMLElement* htmlElement = downcast<HTMLElement>(m_element);

Why don't you also rename setInnerText's htmlEle to htmlElement while you're at it.
Comment 6 peavo 2015-11-24 00:39:58 PST
Committed r192762: <http://trac.webkit.org/changeset/192762>.
Comment 7 peavo 2015-11-24 00:41:30 PST
(In reply to comment #5)
> Comment on attachment 266093 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266093&action=review
> 
> This looks a lot like the innerText implementation just below it :)
> r=me, mac test failures unrelated.
> 

Yes, I must admit I was highly inspired by this code when I sat down to write this method :)

Thanks for reviewing :)