Bug 151569 – [Win] Implement methods to get and set inner html.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

DOMHTMLElement::innerHTML and DOMHTMLElement::setInnerHTML are not implemented on Windows yet.

Created attachment 266092 [details]
Patch

Created attachment 266093 [details]
Patch

[Build Bot]

Comment on attachment 266093 [details]
Patch

Attachment 266093 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/468549

New failing tests:
js/property-name-enumerator-gc-151495.html

[Build Bot]

Created attachment 266094 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Alex Christensen]

Comment on attachment 266093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266093&action=review

This looks a lot like the innerText implementation just below it :)
r=me, mac test failures unrelated.

> Source/WebKit/win/DOMHTMLClasses.cpp:507
> +    String innerHtmlString = downcast<HTMLElement>(m_element)->innerHTML();

innerHTMLString

> Source/WebKit/win/DOMHTMLClasses.cpp:515
> +    HTMLElement* htmlElement = downcast<HTMLElement>(m_element);

Why don't you also rename setInnerText's htmlEle to htmlElement while you're at it.

Committed r192762: <http://trac.webkit.org/changeset/192762>.

(In reply to comment #5)
> Comment on attachment 266093 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266093&action=review
> 
> This looks a lot like the innerText implementation just below it :)
> r=me, mac test failures unrelated.
> 

Yes, I must admit I was highly inspired by this code when I sat down to write this method :)

Thanks for reviewing :)