Bug 151550 – Modern IDB: When a transaction is aborted, call onerror handlers for all in-progress requests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: When a transaction is aborted, call onerror handlers for all in-progress requests

[Brady Eidson]

Created attachment 266061 [details]
Patch v1

[Alex Christensen]

Comment on attachment 266061 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=266061&action=review

r=me except one comment.

> Source/WebCore/Modules/indexeddb/shared/IDBError.cpp:117
> +        static NeverDestroyed<String> entry = ASCIILiteral("Real description for abort");

This looks like you meant to get to this before uploading the patch.  This tells me the error descriptions aren't checked in the tests.  Will this be covered in https://bugs.webkit.org/show_bug.cgi?id=150402

[Brady Eidson]

(In reply to comment #2)
> Comment on attachment 266061 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266061&action=review
> 
> r=me except one comment.
> 
> > Source/WebCore/Modules/indexeddb/shared/IDBError.cpp:117
> > +        static NeverDestroyed<String> entry = ASCIILiteral("Real description for abort");
> 
> This looks like you meant to get to this before uploading the patch.  

Indeed! Yikes, and LOL.

> This tells me the error descriptions aren't checked in the tests.  Will this be
> covered in https://bugs.webkit.org/show_bug.cgi?id=150402

Yup! 150402 will basically be a task that greps through the entire set of -expectations.txt to make sure each error desc shows up at least once, but 150882 is a pre-requisite for that.

Coincidentally, 150882 is what I'm trying to work on over the next couple of days.

[Brady Eidson]

Created attachment 266091 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 266091 [details]
Patch for landing

Clearing flags on attachment: 266091

Committed r192749: <http://trac.webkit.org/changeset/192749>