Bug 151549 – Rename JavaScriptCore builtins files to match exposed object names

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Blaze Burg]

As a subtask of unifying code generation for WebCore and JSC builtins, we need to get rid of differences between builtins filenames (e.g., Operations.Promise.js, Promise.prototype.js) and the name of the generated Builtin object (OperationsPromise, PromisePrototype). If we don't do this, then both build systems need special hacks to normalize the object name from the file name. It's easier to just normalize the filename.

[Blaze Burg]

Created attachment 266057 [details]
Proposed Fix

[Blaze Burg]

Created attachment 266058 [details]
Proposed Fix

[youenn fablet]

Comment on attachment 266058 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266058&action=review

Looks like the right direction to me.

> Source/JavaScriptCore/CMakeLists.txt:1198
>      ${JAVASCRIPTCORE_DIR}/builtins/GlobalObject.js

This filename has no suffix. Is it ok? Should we think of renaming it also?

> Source/JavaScriptCore/CMakeLists.txt:1204
> +    ${JAVASCRIPTCORE_DIR}/builtins/OperationsPromise.js

I would rename it to PromiseXXX.js so that it gets closer to other Promise related files.
If we were to follow WebCore, it would be named PromiseInternals.js, which would relate to @internal annotation.

[Blaze Burg]

Comment on attachment 266058 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266058&action=review

>> Source/JavaScriptCore/CMakeLists.txt:1198
>>      ${JAVASCRIPTCORE_DIR}/builtins/GlobalObject.js
> 
> This filename has no suffix. Is it ok? Should we think of renaming it also?

I think it's okay, it's a singleton like ReflectObject and InspectorInstrumentationObject, and it can't be constructed.

>> Source/JavaScriptCore/CMakeLists.txt:1204
>> +    ${JAVASCRIPTCORE_DIR}/builtins/OperationsPromise.js
> 
> I would rename it to PromiseXXX.js so that it gets closer to other Promise related files.
> If we were to follow WebCore, it would be named PromiseInternals.js, which would relate to @internal annotation.

OK

[youenn fablet]

Comment on attachment 266058 [details]
Proposed Fix

r=me

[Blaze Burg]

Committed r192751: <http://trac.webkit.org/changeset/192751>