Bug 151538 – [iOS] Option-up and Option-down should scroll a little less than a full page

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

[iOS] Option-up and Option-down should scroll a little less than a full page

[Tim Horton]

Created attachment 266041 [details]
Patch

[Tim Horton]

Looking into writing a test, will have to plumb the ability to use arbitrary modifiers when sending key events.

[WebKit Commit Bot]

Attachment 266041 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2882:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 266041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266041&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2868
> +- (Optional<FloatPoint>)_scrollOffsetForEvent:(WebIOSEvent *)event

FloatSize?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885
> +        CGFloat scrollDistance = ^ CGFloat {

Not sure what's happening here.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2907
> +        return computeOffset(Line, Left);

I would prefer blank lines after all the returns.

[Tim Horton]

(In reply to comment #4)
> Comment on attachment 266041 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266041&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2868
> > +- (Optional<FloatPoint>)_scrollOffsetForEvent:(WebIOSEvent *)event
> 
> FloatSize?

_scrollByContentOffset takes a FloatPoint :D

> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885
> > +        CGFloat scrollDistance = ^ CGFloat {
> 
> Not sure what's happening here.

Blocks, man!

No, but really, that's the syntax for when you want to explicitly state the return type of a block. Which I need to do because of the 0 (and the ints). Or I could cast all of those but I hate that more.

> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2907
> > +        return computeOffset(Line, Left);
> 
> I would prefer blank lines after all the returns.

Sure.

[Tim Horton]

http://trac.webkit.org/changeset/192811