RESOLVED FIXED 151502
[GTK] Non-symbolic icons used for edit-find and edit-clear 
https://bugs.webkit.org/show_bug.cgi?id=151502
Summary [GTK] Non-symbolic icons used for edit-find and edit-clear
Michael Catanzaro
Reported 2015-11-20 10:40:09 PST
RenderThemeGtk.cpp improperly uses color icons in paintSearchFieldResultsDecorationPart(), paintSearchFieldCancelButton(), and paintCapsLockIndicator(). The proper icons would be edit-find-symbolic, edit-clear-symbolic, and dialog-warning-symbolic, respectively. I tried to fix this by calling getStockSymbolicIconForWidgetType() rather than getStockIconForWidgetType() in those functions, but the icons in the search entry didn't display unless I removed the flag GTK_ICON_LOOKUP_FORCE_SIZE from the call to gtk_icon_theme_lookup_icon() in getStockSymbolicIconForWidgetType(), and then they displayed blurry, which is weird for symbolic icons, so I was doing something wrong. Testcase for the search entry is to open the web inspector and look in the upper right.
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-12-09 04:13:57 PST
Better testcase: the search box on https://www.wikipedia.org/ The magnifying glass icon should be monochrome, not blue.
Carlos Garcia Campos
Comment 2 2016-01-11 04:52:35 PST
Fixed in r194847
Note You need to log in before you can comment on or make changes to this bug.