Bug 151490 - [GTK] Some unit tests fail when using the network process
Summary: [GTK] Some unit tests fail when using the network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-11-20 05:00 PST by Carlos Garcia Campos
Modified: 2015-11-22 01:00 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.34 KB, patch)
2015-11-20 06:39 PST, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-11-20 05:00:34 PST 
/webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT

/webkit2/WebKitWebResource/get-data: **
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached

/webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT
Comment 1 Carlos Garcia Campos 2015-11-20 06:33:30 PST 
(In reply to comment #0)
> /webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT

This works with the web process only because all request started are done before the first subresource is processed by the server, something that doesn't happen when using the network process. We are using mutexes in the same main thread, the soup server should run in a separate thread for this to work properly.

> /webkit2/WebKitWebResource/get-data: **
> ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void
> ResourcesTest::checkResourceData(WebKitWebResource*): code should not be
> reached

I haven't investigated this yet, but running the soup server in a thread also fixed this one.

> /webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT

No idea about this one, yet. I'll submit a patch to fix the other two for now.
Comment 2 Carlos Garcia Campos 2015-11-20 06:39:07 PST 
Created attachment 265952 [details]
Patch
Comment 3 Carlos Garcia Campos 2015-11-22 00:56:42 PST 
(In reply to comment #0)
> /webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT
> 
> /webkit2/WebKitWebResource/get-data: **
> ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void
> ResourcesTest::checkResourceData(WebKitWebResource*): code should not be
> reached
> 
> /webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT

This one is timing out for me locally even when using the web process, so it's ot related.
Comment 4 Carlos Garcia Campos 2015-11-22 01:00:58 PST 
Committed r192729: <http://trac.webkit.org/changeset/192729>