Bug 151490 – [GTK] Some unit tests fail when using the network process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

/webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT

/webkit2/WebKitWebResource/get-data: **
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void ResourcesTest::checkResourceData(WebKitWebResource*): code should not be reached

/webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT

[Carlos Garcia Campos]

(In reply to comment #0)
> /webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT

This works with the web process only because all request started are done before the first subresource is processed by the server, something that doesn't happen when using the network process. We are using mutexes in the same main thread, the soup server should run in a separate thread for this to work properly.

> /webkit2/WebKitWebResource/get-data: **
> ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void
> ResourcesTest::checkResourceData(WebKitWebResource*): code should not be
> reached

I haven't investigated this yet, but running the soup server in a thread also fixed this one.

> /webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT

No idea about this one, yet. I'll submit a patch to fix the other two for now.

[Carlos Garcia Campos]

Created attachment 265952 [details]
Patch

[Carlos Garcia Campos]

(In reply to comment #0)
> /webkit2/WebKitWebView/sync-request-on-max-conns: TIMEOUT
> 
> /webkit2/WebKitWebResource/get-data: **
> ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:195:void
> ResourcesTest::checkResourceData(WebKitWebResource*): code should not be
> reached
> 
> /webkit2/WebKitAccessibility/atspi-basic-hierarchy: TIMEOUT

This one is timing out for me locally even when using the web process, so it's ot related.

[Carlos Garcia Campos]

Committed r192729: <http://trac.webkit.org/changeset/192729>