Bug 151484 - Modern IDB: Get IDBRequest.readyState right
Summary: Modern IDB: Get IDBRequest.readyState right
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2015-11-19 22:23 PST by Brady Eidson
Modified: 2015-11-20 10:55 PST (History)
5 users (show)

See Also:

Attachments
Patch v1 (5.40 KB, patch)
2015-11-20 09:41 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-11-19 22:23:24 PST 
Modern IDB: Get IDBRequest.readyState right

Not much effort gone in to getting it right so far.

Revealed on many of the legacy tests, such as storage/indexeddb/mozilla/add-twice-failure.html
Comment 1 Brady Eidson 2015-11-19 22:31:23 PST 
(In reply to comment #0)
> Modern IDB: Get IDBRequest.readyState right
> 
> Not much effort gone in to getting it right so far.

Actually, it appears we do keep the flag updated appropriately, but we just never returned the correct string for the readyState accessor.

Doh!
Comment 2 Brady Eidson 2015-11-20 09:41:28 PST 
Created attachment 265963 [details]
Patch v1
Comment 3 WebKit Commit Bot 2015-11-20 10:55:17 PST 
Comment on attachment 265963 [details]
Patch v1

Clearing flags on attachment: 265963

Committed r192686: <http://trac.webkit.org/changeset/192686>
Comment 4 WebKit Commit Bot 2015-11-20 10:55:20 PST 
All reviewed patches have been landed.  Closing bug.