Bug 151475 - Back-buffer to front-buffer copy fails for some buffer formats
Summary: Back-buffer to front-buffer copy fails for some buffer formats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-19 19:19 PST by Simon Fraser (smfr)
Modified: 2015-11-20 12:07 PST (History)
3 users (show)

See Also:


Attachments
Patch (9.62 KB, patch)
2015-11-19 19:25 PST, Simon Fraser (smfr)
thorton: review+
thorton: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-11-19 19:19:15 PST
Back-buffer to front-buffer copy fails for some buffer formats
Comment 1 Simon Fraser (smfr) 2015-11-19 19:25:58 PST
Created attachment 265929 [details]
Patch
Comment 2 Tim Horton 2015-11-19 19:29:15 PST
Comment on attachment 265929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265929&action=review

> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm:339
> +    if (m_isOpaque)

Fill after the back buffer copy???
Comment 3 Tim Horton 2015-11-19 19:38:22 PST
No CQ, it doesn't build. Also, it seems to me like the fill is in the wrong place and opaque layers will be very red when repainted in debug builds.
Comment 4 Simon Fraser (smfr) 2015-11-20 11:15:20 PST
Comment on attachment 265929 [details]
Patch

Tim really meant r-
Comment 5 Tim Horton 2015-11-20 11:46:10 PST
The problems weren't really big enough for that :D
Comment 6 Simon Fraser (smfr) 2015-11-20 12:07:33 PST
rdar://problem/23617899

https://trac.webkit.org/r192689