RESOLVED FIXED 151463
FTL->B3 lowering should support integer comparisons with the opcode abstracted and a few other things 
https://bugs.webkit.org/show_bug.cgi?id=151463
Summary FTL->B3 lowering should support integer comparisons with the opcode abstracte...
Filip Pizlo
Reported 2015-11-19 14:10:49 PST
Patch forthcoming.
Attachments
the patch (10.12 KB, patch)
2015-11-19 14:12 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-11-19 14:12:09 PST
Created attachment 265902 [details] the patch
WebKit Commit Bot
Comment 2 2015-11-19 14:15:00 PST
Attachment 265902 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4526: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4675: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4678: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4690: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4699: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4711: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4714: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 9 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-11-19 14:15:59 PST
Comment on attachment 265902 [details] the patch r=me
Filip Pizlo
Comment 4 2015-11-19 14:18:36 PST
Landed in http://trac.webkit.org/changeset/192659
Note You need to log in before you can comment on or make changes to this bug.