Bug 151443 - [EFL] Fix -Winconsistent-missing-override clang warnings
Summary: [EFL] Fix -Winconsistent-missing-override clang warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency treegraph
 
Reported: 2015-11-19 05:26 PST by Csaba Osztrogonác
Modified: 2015-11-19 09:38 PST (History)
2 users (show)

See Also:


Attachments
Patch (11.56 KB, patch)
2015-11-19 05:30 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-11-19 05:26:27 PST
../../Source/WebCore/loader/EmptyClients.h:133:18: warning: 'delegatedScrollRequested' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    virtual void delegatedScrollRequested(const IntPoint&) { }
                 ^
../../Source/WebCore/page/ChromeClient.h:168:18: note: overridden virtual function is here
    virtual void delegatedScrollRequested(const IntPoint&) = 0;
                 ^
In file included from ../../Source/WebCore/page/MainFrame.cpp:30:
../../Source/WebCore/loader/EmptyClients.h:136:18: warning: 'scheduleAnimation' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    virtual void scheduleAnimation() { }
                 ^
../../Source/WebCore/page/ChromeClient.h:183:18: note: overridden virtual function is here
    virtual void scheduleAnimation() = 0;
                 ^

And there are many similar warnings should be fixed.
Comment 1 Csaba Osztrogonác 2015-11-19 05:30:47 PST
Created attachment 265862 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-19 09:38:48 PST
Comment on attachment 265862 [details]
Patch

Clearing flags on attachment: 265862

Committed r192628: <http://trac.webkit.org/changeset/192628>
Comment 3 WebKit Commit Bot 2015-11-19 09:38:52 PST
All reviewed patches have been landed.  Closing bug.