Bug 151432 - [JSC] Add bitwise Double-Int conversion to B3
Summary: [JSC] Add bitwise Double-Int conversion to B3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-18 21:44 PST by Benjamin Poulain
Modified: 2015-11-19 00:38 PST (History)
6 users (show)

See Also:


Attachments
Patch (17.91 KB, patch)
2015-11-18 21:47 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (17.93 KB, patch)
2015-11-18 21:56 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-11-18 21:44:00 PST
[JSC] Add bitwise Double-Int conversion to B3
Comment 1 Benjamin Poulain 2015-11-18 21:47:08 PST
Created attachment 265844 [details]
Patch
Comment 2 Benjamin Poulain 2015-11-18 21:56:01 PST
Created attachment 265846 [details]
Patch
Comment 3 Filip Pizlo 2015-11-18 22:15:00 PST
Comment on attachment 265846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265846&action=review

> Source/JavaScriptCore/b3/air/AirOpcode.opcodes:240
> +    Addr, Tmp as loadDouble

Could also add the store variants. :-) That will give the spiller more options.
Comment 4 Benjamin Poulain 2015-11-18 23:49:58 PST
Comment on attachment 265846 [details]
Patch

(In reply to comment #3)
> Comment on attachment 265846 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265846&action=review
> 
> > Source/JavaScriptCore/b3/air/AirOpcode.opcodes:240
> > +    Addr, Tmp as loadDouble
> 
> Could also add the store variants. :-) That will give the spiller more
> options.

There is something fishy with that one. I'll look into it later.
Comment 5 WebKit Commit Bot 2015-11-19 00:38:23 PST
Comment on attachment 265846 [details]
Patch

Clearing flags on attachment: 265846

Committed r192619: <http://trac.webkit.org/changeset/192619>
Comment 6 WebKit Commit Bot 2015-11-19 00:38:27 PST
All reviewed patches have been landed.  Closing bug.